Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft of updated doc for sampling params. #3260

Merged
merged 12 commits into from
Feb 16, 2025
Merged

Draft of updated doc for sampling params. #3260

merged 12 commits into from
Feb 16, 2025

Conversation

simveit
Copy link
Contributor

@simveit simveit commented Feb 2, 2025

Motivation

This PR intends to update the docs on sampling parameters as suggested here

Modifications

New docs for sampling params

Checklist

@zhaochenyang20 zhaochenyang20 mentioned this pull request Feb 12, 2025
Merged
shuaills
shuaills suggested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@shuaills shuaills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@zhaochenyang20
Copy link
Collaborator

@simveit Should this be ready?

@simveit
Copy link
Contributor Author

simveit commented Feb 16, 2025

@zhaochenyang20 IMO yes.
what do you think @shuaills ?

@zhaochenyang20
Copy link
Collaborator

If so, turn ready to review, thanks!

@simveit simveit marked this pull request as ready for review February 16, 2025 18:48
shuaills
shuaills approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@shuaills shuaills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhaochenyang20
zhaochenyang20 approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G reat job @shuaills @simveit

@zhaochenyang20 zhaochenyang20 merged commit 8f13377 into sgl-project:main Feb 16, 2025
12 checks passed
@simveit simveit deleted the feature/sampling-params branch February 17, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaochenyang20 zhaochenyang20 zhaochenyang20 approved these changes

@shuaills shuaills shuaills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simveit @zhaochenyang20 @shuaills